-
Notifications
You must be signed in to change notification settings - Fork 86
Updated Cluster Proxy Setup docs #449
base: master
Are you sure you want to change the base?
Updated Cluster Proxy Setup docs #449
Conversation
Hi @danimo! It would be great if you could test this changes and contribute with your ideas, since you've been working on that area. Best regards! |
@@ -157,6 +180,14 @@ location =/html5client/locale { | |||
} | |||
``` | |||
|
|||
Add the following piece into the `location /bbb-01/html5client/locales` directive in `/usr/share/bigbluebutton/nginx/bbb-html5.nginx`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just go into the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Sorry for the late. Could you please elaborate? I don't have much experience with the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a separate commit to bigbluebutton/build/packages-template/bbb-html5/bbb-html5.nginx
with these changes. They will be part of the packages in the next nightly build.
This works for me with the changes described in the review. |
it was merged. Should we merge this now? |
Only once the changes that I outlined in the review are applied. |
sub_filter 'src="/learning' 'src="/bbb-01/learning'; | ||
sub_filter 'href="/learning' 'href"/bbb-01/learning'; | ||
sub_filter 'href="/favicon' 'href="/bbb-01/favicon'; | ||
sub_filter '/html5client' 'https://bbb-01.example.com/bbb-01/html5client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to point to the cluster vhost, not the nodes host:
|
||
sub_filter_types text/html text/css text/xml application/javascript; | ||
sub_filter 'src="/learning' 'src="/bbb-01/learning'; | ||
sub_filter 'href="/learning' 'href"/bbb-01/learning'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- sub_filter 'href="/learning' 'href"/bbb-01/learning';
+ sub_filter 'href="/learning' 'href="/bbb-01/learning';
sub_filter 'href="/learning' 'href"/bbb-01/learning'; | ||
sub_filter 'href="/favicon' 'href="/bbb-01/favicon'; | ||
sub_filter '/html5client' 'https://bbb-01.example.com/bbb-01/html5client'; | ||
sub_filter '/bigbluebutton/api/learningDashboard' 'https://bbb-01.example.com/bigbluebutton/api/learningDashboard'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-sub_filter '/bigbluebutton/api/learningDashboard' 'https://bbb-01.example.com/bigbluebutton/api/learningDashboard';
+sub_filter '/bigbluebutton/' 'https://bbb-01.example.com/bigbluebutton/';
Otherwise the presentation previews provided under /bigbluebutton/presentation
will be loaded from the cluster proxy, not the node.
@@ -157,6 +180,14 @@ location =/html5client/locale { | |||
} | |||
``` | |||
|
|||
Add the following piece into the `location /bbb-01/html5client/locales` directive in `/usr/share/bigbluebutton/nginx/bbb-html5.nginx`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a separate commit to bigbluebutton/build/packages-template/bbb-html5/bbb-html5.nginx
with these changes. They will be part of the packages in the next nightly build.
Sorry, I had a review open that I forgot to submit. |
Updated Cluster Proxy Setup docs regarding the Dashboard.
Include what's necessary for the Dashboard to properly work when using Cluster Proxy Setup